Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update time in draft to account for edge cases and update tests #431

Merged
merged 4 commits into from
Dec 1, 2024
Merged

fix: Update time in draft to account for edge cases and update tests #431

merged 4 commits into from
Dec 1, 2024

Conversation

brokoli777
Copy link
Contributor

@brokoli777 brokoli777 commented Nov 26, 2024 •
edited by zkoppert
Loading

Pull Request

Proposed Changes

Fixes: #417

  • Updated the time in draft to work even if a pr has been changed from ready for review to draft by using the events from the issues object.
  • Also updated the test cases to reflect and test the new changes.

image

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

image

image

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking

@github-actions github-actions bot added the fix label Nov 26, 2024
zkoppert
zkoppert approved these changes Dec 1, 2024
View reviewed changes
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Code was easy to follow and well tested.

@zkoppert zkoppert merged commit dcfd440 into github:main Dec 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkoppert zkoppert zkoppert approved these changes

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@sutterj sutterj Awaiting requested review from sutterj sutterj is a code owner

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potentially inaccurate time in draft
2 participants
@brokoli777 @zkoppert