-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gradle build files and tested gradle versions in CI #630
Conversation
current gradle in CI is 8.x - add previous current, 7.6, to run in CI - update 6.4 -> 6.9.3 - bump plugins in build.gradle files causing CI failures
it only looks like it was needed due to how tests were set up with the fixtures folder set to the multi_project folder rather than the expected source path
1. runtime -> runtimeOnly 2. create custom configurations that extend from the real configurations being used to work around Gradle core configurations not being resolvable
I needed to make deeper changes to the code and tests to get things fully working for Gradle 8. I was having trouble getting tests to work as I was expecting them to, and the following commits were made to try and get things in a more predictable place.
At this point I was able to fix the problems that surfaced after updating plugin versions
Along the way I also put in a bug fix and a small code cleanup
|
@LouisBoudreau 👋 would you be able to take a look at this change, specifically c5c5c2d? It looks like that change is working, but I'm not sure if it's the best solution.
|
Yes, I will check this out friday! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a really simple proposition here that could be merged into this PR before merging this one.
Thanks for cleaning up the code and updating the gradle source 🙇
To close the collaboration loop, I closed that PR and will not be bringing any of the changes proposed into this PR before merging. It's a good proposal and I'm going to open an issue to re-evaluate the default Gradle configurations used for dependency enumeration, but that change likely needs to coincide with a major version bump since there's a chance that it could be a breaking change for users. If conversation on the issue shows that it wouldn't be a breaking change then it's also really easy to remove |
current gradle in CI was recently changed to 8.x, and the update of 7.9 -> 8.0 looks to have been causing issues due to a new deprecation with the versions of the kotlin jvm and gradle plugin that were used in the test fixtures'
build.gradle
files. I made a few changes that I'm hoping will fix this.