Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update no-empty-alt-text to check for no alt #88

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Conversation

kendallgassner
Copy link
Contributor

What

Update no-empty-alt-text to account for two additional cases

  • <img alt src=''/>
  • <img src=''/>

@kendallgassner kendallgassner requested a review from a team as a code owner October 10, 2023 16:14
@github-actions
Copy link

Uh oh! @kendallgassner, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

@kendallgassner kendallgassner requested a review from khiga8 October 10, 2023 16:17
Copy link
Contributor

@khiga8 khiga8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, thanks for adding this :)

src/rules/no-empty-alt-text.js Show resolved Hide resolved
test/no-empty-alt-text.test.js Show resolved Hide resolved
Copy link
Contributor

@khiga8 khiga8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, meant to request changes

@kendallgassner kendallgassner requested a review from khiga8 October 10, 2023 21:59
Copy link
Contributor

@khiga8 khiga8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!!

@kendallgassner kendallgassner merged commit 74fe5f9 into main Oct 11, 2023
1 check passed
@kendallgassner kendallgassner deleted the addNoAltCheck branch October 11, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants