[PRISM] prevent underflow on popped splatarray (ruby#8657)

prevent underflow on popped splatarray This only emits the splat array node when not popped
github · Oct 16, 2023 · 6e88b72 · 6e88b72
1 parent 06a4011
commit 6e88b72
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/prism_compile.c b/prism_compile.c
@@ -2397,9 +2397,9 @@ pm_compile_node(rb_iseq_t *iseq, const pm_node_t *node, LINK_ANCHOR *const ret,
             PM_COMPILE(splat_node->expression);
         }
 
-        ADD_INSN1(ret, &dummy_line_node, splatarray, Qtrue);
-
-        PM_POP_IF_POPPED;
+        if (!popped) {
+            ADD_INSN1(ret, &dummy_line_node, splatarray, Qtrue);
+        }
         return;
       }
       case PM_STATEMENTS_NODE: {

diff --git a/test/ruby/test_compile_prism.rb b/test/ruby/test_compile_prism.rb
@@ -325,6 +325,10 @@ def test_HashNode
       test_prism_eval("[ Prism: [:b, :c]]")
     end
 
+    def test_SplatNode
+      test_prism_eval("*b = []")
+    end
+
     ############################################################################
     # Jumps                                                                    #
     ############################################################################