Add 'context' to mergeDeep name fields #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Harding <kyle@balena.io>
This allows mergeDeep to correctly identify changes to required_status_checks in rulesets Signed-off-by: Kyle Harding <kyle@balena.io>
klutchell
force-pushed
the
kyle/ruleset-checks
branch
from
d59faf0 to
ac1dbc3
Compare
|
@JakubBiel @luvsaxena1 This PR seems to resolve the issue mentioned in this comment: #655 (comment) |
|
@decyjphr can we get this merged please? We've been running this version for a few weeks with no issues. |
|
@klutchell thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #655
This PR adds a new failing test case for detecting changes to
required_status_checksin rulesets.It then fixes the issue by adding
contextto the supported named keys in mergeDeep.