Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accounts): warn when missing scopes #1688

Merged
merged 11 commits into from
Dec 28, 2024
Merged

feat(accounts): warn when missing scopes #1688

merged 11 commits into from
Dec 28, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Dec 25, 2024

closes #1685

Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy setchy added this to the Release 5.18.0 milestone Dec 25, 2024
@github-actions github-actions bot added the enhancement New feature or enhancement to existing functionality label Dec 25, 2024
@setchy setchy marked this pull request as draft December 25, 2024 18:07
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy setchy marked this pull request as ready for review December 26, 2024 07:19
Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to show which scopes are missing, if it's not too much trouble. Looks good otherwise!

Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy setchy merged commit d1ba3ca into main Dec 28, 2024
11 checks passed
@setchy setchy deleted the feat/pat-scopes-check branch December 28, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(accounts): add warning when accounts don't have all required scopes
2 participants