Skip to content

Commit

Permalink
Node 19 -> Node 20 (#1187)
Browse files Browse the repository at this point in the history
  • Loading branch information
filiptronicek authored Oct 2, 2023
1 parent 963f276 commit 5130a2e
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 6 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

A curated, chronologically ordered list of notable changes in [Gitpod's default workspace images](https://hub.docker.com/u/gitpod).

## 2023-10-02

- For `workspace-node`, deprecate Node 19 in favor of Node 20

## 2023-09-18

- Bump Rust to `1.72.0`
Expand Down
4 changes: 2 additions & 2 deletions chunks/lang-node/chunk.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ variants:
- name: "18"
args:
NODE_VERSION: 18.18.0
- name: "19"
- name: "20"
args:
NODE_VERSION: 19.9.0
NODE_VERSION: 20.8.0
2 changes: 1 addition & 1 deletion dazzle.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ combiner:
ref:
- base
chunks:
- lang-node:19
- lang-node:20
- tool-chrome
- name: node-lts
ref:
Expand Down
6 changes: 3 additions & 3 deletions tests/lang-node.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
assert:
- status == 0
- stdout.indexOf("v18") != -1 ||
stdout.indexOf("v19") != -1
stdout.indexOf("v20") != -1
- desc: it should have yarn
command: [yarn --version]
entrypoint: [bash, -i, -c]
Expand All @@ -20,12 +20,12 @@
entrypoint: [bash, -i, -c]
assert:
- status == 0
- desc: it should yarn work
- desc: it should have working yarn
command: [yarn global add envinfo]
entrypoint: [bash, -i, -c]
assert:
- status == 0
- desc: it should pnpm work
- desc: it should have working pnpm
command: [pnpm i -g envinfo]
entrypoint: [bash, -i, -c]
assert:
Expand Down

0 comments on commit 5130a2e

Please sign in to comment.