Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ninja-build to full. #357

Closed
gengjiawen opened this issue Feb 24, 2021 · 2 comments · Fixed by #359
Closed

Add ninja-build to full. #357

gengjiawen opened this issue Feb 24, 2021 · 2 comments · Fixed by #359
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@gengjiawen
Copy link
Contributor

It's a very popular tools, used to build V8 and Node.js. Very essential to c/cpp devs. Also it's very small, around 100kb.

@jankeromnes jankeromnes added enhancement New feature or request help wanted Extra attention is needed labels Feb 24, 2021
@jankeromnes
Copy link
Contributor

Thanks for the suggestion! That's a good idea.

My only worries would be:

  • What size delta would this add to gitpod/workspace-full? (We can assess this by starting a PR and compare the built image with master)

  • Do we know for sure that projects will pickup and use our installed Ninja? (It seems to me that many projects now download a custom toolchain as part of their build process, bypassing our installed tools -- for example, I believe Chromium and Firefox both download latest Clang to build, even though Gitpod already has latest Clang installed)

@gengjiawen
Copy link
Contributor Author

What size delta would this add to gitpod/workspace-full?

Since docker has compression. I would expect like less than 100kb. I will start a PR later :)

I believe Chromium and Firefox both download latest Clang to build

Yeap, they have internal toolchain. But https://github.com/bnoordhuis/v8-cmake can benefit from this.
Also, we start using Node.js ninja build in CI, see nodejs/node#37499.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants