Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full]: add ninja-build #359

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Conversation

gengjiawen
Copy link
Contributor

Fix #357

@gitpod-io
Copy link

gitpod-io bot commented Feb 24, 2021

Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Many thanks @gengjiawen 💯

@jankeromnes jankeromnes merged commit 310793c into gitpod-io:master Feb 25, 2021
@gengjiawen gengjiawen deleted the featurn/ninja branch February 25, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ninja-build to full.
2 participants