node: LTS and major release changes #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/gitpod-io/workspace-images/blob/main/tests/lang-node.yaml#L6 should be updated. Also I think we shouldn't keep node-18, users need it can install it by nvm. |
kylos101
reviewed
Oct 18, 2023
There was a problem hiding this comment.
As @gengjiawen mentioned, tests are failing here.
@filiptronicek , personally I like the idea of adding node-18. @loujaybee, @laushinka is the strategy to go towards more explicitly versioned images? I ask because there are others (like Rust).
Please re-request a review when needed.
kylos101
approved these changes
Oct 18, 2023
nice work, as usual, Mr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Node 21 was just released and Node 20 is becoming the LTS today.