-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize images #361
Open
genintho
wants to merge
221
commits into
gnachman:master
Choose a base branch
from
genintho:shrinkbot/1528648206
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Optimize images #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89.60 KiB => 48.40 KiB (-45%)
37.51 KiB => 10.72 KiB (-71%)
3.64 KiB => 525.00 B (-85%)
3.65 KiB => 541.00 B (-85%)
11.66 KiB => 3.72 KiB (-68%)
…sparency.png 11.40 KiB => 4.32 KiB (-62%)
…reverseVideoNondefaultBackgroundOnlyUnderCursor.png 4.72 KiB => 1.07 KiB (-77%)
….png 30.71 KiB => 15.89 KiB (-48%)
15.58 KiB => 4.10 KiB (-73%)
…t.png 3.52 KiB => 296.00 B (-91%)
…tAndBg.png 3.53 KiB => 307.00 B (-91%)
7.11 KiB => 2.00 KiB (-71%)
…ithTransparency.png 7.00 KiB => 2.28 KiB (-67%)
2.14 KiB => 753.00 B (-65%)
3.24 KiB => 1.39 KiB (-57%)
…ter.png 9.84 KiB => 3.12 KiB (-68%)
4.80 KiB => 1.11 KiB (-76%)
49.09 KiB => 22.91 KiB (-53%)
…y.png 23.33 KiB => 1.49 KiB (-93%)
…ghBlending.png 9.62 KiB => 5.68 KiB (-40%)
…wBlending.png 8.95 KiB => 4.79 KiB (-46%)
…thGloballyInvertedColors.png 16.03 KiB => 10.98 KiB (-31%)
…thReverseVideo.png 16.01 KiB => 10.32 KiB (-35%)
…thTransparency.png 8.95 KiB => 4.79 KiB (-46%)
….png 80.43 KiB => 23.47 KiB (-70%)
3.42 KiB => 324.00 B (-90%)
…ideo.png 3.48 KiB => 396.00 B (-88%)
4.22 KiB => 707.00 B (-83%)
…n.png 3.50 KiB => 373.00 B (-89%)
…le.png 3.89 KiB => 557.00 B (-86%)
…ndCursorBoost.png 3.98 KiB => 597.00 B (-85%)
…ndCursorBoostAndMinimumContrast.png 3.95 KiB => 568.00 B (-85%)
…ndMinimumContrast.png 3.43 KiB => 338.00 B (-90%)
…sorBoost.png 3.98 KiB => 629.00 B (-84%)
…sorBoostAndMinimumContrast.png 3.95 KiB => 659.00 B (-83%)
…imumContrast.png 3.41 KiB => 338.00 B (-90%)
2.95 KiB => 83.00 B (-97%)
22.95 KiB => 336.00 B (-98%)
…frameAllCursorColor.png 3.25 KiB => 131.00 B (-96%)
6.00 KiB => 3.73 KiB (-37%)
14.03 KiB => 8.65 KiB (-38%)
…r_full.png 137.65 KiB => 96.72 KiB (-29%)
…or_daemon.png 136.76 KiB => 105.56 KiB (-22%)
3.03 KiB => 1.80 KiB (-40%)
7.12 KiB => 3.67 KiB (-48%)
202.00 B => 138.00 B (-31%)
524.00 B => 372.00 B (-29%)
7.12 KiB => 3.67 KiB (-48%)
18.43 KiB => 9.03 KiB (-51%)
524.00 B => 372.00 B (-29%)
1.19 KiB => 847.00 B (-30%)
18.39 KiB => 9.04 KiB (-50%)
54.20 KiB => 22.28 KiB (-58%)
415.86 KiB => 194.04 KiB (-53%)
293.84 KiB => 113.92 KiB (-61%)
1.78 KiB => 520.00 B (-71%)
1.69 KiB => 483.00 B (-72%)
1.04 KiB => 412.00 B (-61%)
Let's not change the files under tests. They aren't distributed and I don't want to pollute their commit history. If you can modify this PR to only touch files in images/ and Media.xcassets/ then I can merge it. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to gnachman/iterm2-website#54, this PR optimize the images in iTerm2 and was generated using (https://www.shrink.sh).
I am really curious to see if the test will pass after the optimization.
🤖 Reduce image sizes by 63%!
Optimized Images
If you are experiencing problems or would like to propose an improvement, 📣 let us know.