Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swift: avoid Connection aborted #897

Merged
merged 1 commit into from
May 22, 2018

Conversation

sileht
Copy link
Member

@sileht sileht commented May 22, 2018

This change removes usage of threads with swift driver.

This avoids to get "Connection aborted" because a thread is stuck
and the server side decide to break the connection.

Related-bug: #509

paramite
paramite previously approved these changes May 22, 2018
chungg
chungg previously approved these changes May 22, 2018
Copy link
Member

@chungg chungg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

jd
jd previously requested changes May 22, 2018
Copy link
Member

@jd jd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be better to implement the add_measures_batch from the incoming driver in swift without parallel_map rather than hacking this way.

@sileht sileht dismissed stale reviews from chungg and paramite via ad655e4 May 22, 2018 13:02
@sileht sileht force-pushed the sileht/swift-parallel-ops branch from f155d2b to ad655e4 Compare May 22, 2018 13:02
@sileht
Copy link
Member Author

sileht commented May 22, 2018

Pull-request updated, HEAD is now ad655e4

@sileht sileht dismissed jd’s stale review May 22, 2018 13:05

I choice another solution

paramite
paramite previously approved these changes May 22, 2018
This change removes usage of threads with swift driver.

This avoids to get "Connection aborted" because a thread is stuck
and the server side decide to break the connection.

Related-bug: gnocchixyz#509
@sileht
Copy link
Member Author

sileht commented May 22, 2018

Pull-request updated, HEAD is now 292c605

@mergify mergify bot merged commit bc18ebd into gnocchixyz:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants