chore: comment Deprecatd -> OptionDeprecated #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanhitt
force-pushed
the
chore/optiondeprecated
branch
from
2ffe37c to
805edd0
Compare
dylanhitt
force-pushed
the
chore/optiondeprecated
branch
from
805edd0 to
62d2187
Compare
|
Lol, that's unfortunate and a bit ironic 😆 Deprecated must obey some rules in Go standard : beginning after a paragraph and be followed by a colon, so your IDE is wrong. But if you get this behaviour, it means you're probably not alone, and I don't want you or any other user to be bothered by this, so yeah I'm ok with this change! |
EwenQuim
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My developer tools complain about this being deprecated when it isn't. Not sure if there is a better way to avoid this