Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: disable route registration when Engine.OpenAPIConfig.Disabled i… #312

Merged

Conversation

dylanhitt
Copy link
Collaborator

Per comment #302 (comment) in #302.

Decided to do this in another MR do it's bit more visible.

Copy link
Collaborator

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 with minor remarks

openapi_test.go Outdated Show resolved Hide resolved
openapi_test.go Outdated Show resolved Hide resolved
@dylanhitt dylanhitt force-pushed the perf/disable-route-registation branch from d95d57b to 9de519c Compare December 26, 2024 13:34
@dylanhitt dylanhitt force-pushed the refactor/OutputOpenAPISpec branch from 178e1e9 to 12d3b26 Compare December 27, 2024 12:58
@dylanhitt dylanhitt force-pushed the perf/disable-route-registation branch from 9de519c to 984a9e9 Compare December 29, 2024 17:01
@dylanhitt dylanhitt merged commit 5c02854 into refactor/OutputOpenAPISpec Dec 29, 2024
4 checks passed
@dylanhitt dylanhitt deleted the perf/disable-route-registation branch December 29, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants