re-implementing default logging middleware

[jwtly10]

This PR implements a simplified default logging middleware, taking on feedback from #303.

These changes simplify #303 and just provides default req/res logging, with options to disable either. Rather than supporting custom logging functions, users who need custom logging can just implement their own mw.

I see some of these use cases:

1. Use default middleware entirely
2. Disable fully/partially disable req&res logging
3. Disable and implement their own logging middleware
4. Use our middleware but override logging funcs

After thinking about how to do this, supporting case 4 does seems unnecessary and more complex that it needs to be - for users needing custom logging it would be cleaner to just implement their own.

Note: Some tests are failing for now due to some golden files not expecting this new middleware by default.

[EwenQuim]

Very good PR!

Looking very close to what I expected, thank you very much.

I'd let the possibility for users to provide their own requestId, that's a really common use case. Just add a func() string in LoggingConfig :)

Thank you again!

[EwenQuim]

Also, I'd add some tests with slogassert. There are some test existing in the codebase that you can mimic.

[jwtly10]

The only thing I haven't addressed yet is failing tests due to including the new mw in open api docs:

 expected: "#### Controller: \n\n`github.com/go-fuego/fuego_test.helloWorld`\n\n---\n\ntest description"
 actual  : "#### Controller: \n\n`github.com/go-fuego/fuego_test.helloWorld`\n\n#### Middlewares:\n\n- `github.com/go-fuego/fuego.NewServer.defaultLoggingMiddleware.func16`\n\n---\n\ntest description"

./examples/petstore/lib/server_test.go: (I guess this would be best fixed with simple golden file update)

openapi_operations_test.go/options_test.go

I'm not sure what the best way to approach this is for these tests. I guess 2 options off the top of my head are

1. disable the middleware for these tests
2. update all the tests to handle this default case of having middleware attached as standard (will also need to change defaultLoggingMiddleware from being an anonymouse function to stop .func16 showing in docs)

Any other ideas?

[EwenQuim]

Please update the tests with make golden-update. The petstore example is an example of Fuego offers out-of-the-box, so it makes sense that the middleware is registered and shown.

We don't want to hide anything

[EwenQuim]

will also need to change defaultLoggingMiddleware from being an anonymouse function to stop .func16 showing in docs

Yes and we need a goodNaming. I suggest defaultLogger? @dylanhitt any idea? If @jwtly10 you have a better idea, don't hesitate :)

Also, I think that if you keep the closure pattern, you'll always have a func in the name. You might need to make a method on a struct to pass arguments. It makes one more alloc on the stack but that should be fine. Maybe struct defaultLogger and the method middleware or handler ?

[jwtly10]

@EwenQuim thanks for the feedback. defaultLogger makes sense for now. I guess it can be changed in future if needed.

Changes have been made, all tests are now passing :)

[dylanhitt]

On mobile, can you send a picture of the way it looks in stoplight?

[jwtly10]

@dylanhitt Not sure what you mean? Do you mean how the open api spec renders when it has this middleware? (using stoplight on mobile?)

If I am completely misunderstanding and you mean you're on mobile and would like a screenshot, here you go, its the pet open api doc:

[dylanhitt]

Oh no, the screenshot is what I needed. Thank you. I like this

[dylanhitt]

I believe @EwenQuim request changes have been addressed. This closes #265

Thank you for the work @jwtly10! We appreciate it.

Cheers