Feat/#issue284 #325
Open
Feat/#issue284 #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwenQuim
requested changes
Dec 30, 2024
server.go
Outdated
| } | ||
| } | ||
|
|
||
| // WithCorsMiddleware is deprecated: Use WithGlobalMiddleware instead. |
There was a problem hiding this comment.
Please use the same syntax than all other deprecated notices, the one understood by Go editors and godoc : skip line then write Deprecated: xxx.
Also, please reference [WithGlobalMiddlewares] with brackets so it can be recognized by other Go tools like Godoc :)
ccoVeille
reviewed
Dec 30, 2024
| } | ||
| } |
There was a problem hiding this comment.
Why such a change?
You could add a commit if it's about formatting files
server.go
Outdated
Comment on lines
46
to
47
| // For example, it allows OPTIONS /foo even if it is not declared (only GET /foo is declared). | ||
| corsMiddleware func(http.Handler) http.Handler |
There was a problem hiding this comment.
Do you still need this then?
There was a problem hiding this comment.
True, as it is not exposed, we can remove it, no need for deprecation notice!
test output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: replace WithCorsMiddleware by WithGlobalMiddleware