Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: issue 321 (Wrap Errors where applicable) #331

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

ZwangaMukwevho
Copy link
Contributor

Summary

This pull requests wraps the errors on the saveOpenAPIToFile(jsonSpecLocalPath string, jsonSpec []byte) for better traceability and debugging

Issue

Addresses this issue 321

Copy link
Collaborator

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have updated the PR title to be more meaningful but except that I'm OK

@ZwangaMukwevho ZwangaMukwevho changed the title chore: issue 321 chore: issue 321 (Wrap Errors where applicable) Jan 4, 2025
@ZwangaMukwevho
Copy link
Contributor Author

I would have updated the PR title to be more meaningful but except that I'm OK

Thanks for having a quick look. I've update the title as well

@dylanhitt
Copy link
Collaborator

Thanks for the contribution!

You may want to base on #302. If not, I can deal with the conflict later.

Copy link
Member

@EwenQuim EwenQuim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your PR!

@EwenQuim EwenQuim merged commit e3bc234 into go-fuego:main Jan 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants