WIP: Support performance trace #32973
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/translation
modifies/go
wxiaoguang
force-pushed
the
support-trace
branch
5 times, most recently
from
a40eb1b to
bd47ebb
Compare
wxiaoguang
force-pushed
the
support-trace
branch
from
bd47ebb to
4b7547b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quite early version, just FYI.
Background: OpenTelemetry is cool for k8s, or users who have setup a complete infrastructure.
For many small to medium instance users who only use single binary installation or docker-compose installation, it seems too heavy for them to install OpenTelemetry eco-system tools to collect performance reports.
This PR introduces an OpenTelemetry-like "tracer" shim-layer and introduces a simple builtin tracer, then every site admin could open their admin panel to find the performance trace logs and report them to Gitea's issue tracker to help to resolve the performance problems.
For advanced users, they could also introduce the OpenTelemetry tracer by implementing "traceStarter interface" (just like
trace_builtin.go). To be discussed: In the future, if the OpenTelemetry integration is mature enough and eco-system tools could be packed into Gitea's release package and many users need to use it out-of-box, then we could provide OpenTelemetry exporter officially.This PR is still at early stage, discussions could go to #32866
screenshots