Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the installation page #32994

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kerwin612
Copy link
Member

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 26, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 26, 2024
@github-actions github-actions bot added modifies/translation modifies/templates This PR modifies the template files labels Dec 26, 2024
@kerwin612 kerwin612 requested a review from lunny December 26, 2024 14:24
@lunny
Copy link
Member

lunny commented Dec 26, 2024

Could you post a screenshot?

@kerwin612
Copy link
Member Author

kerwin612 commented Dec 27, 2024

Could you post a screenshot?

image

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 27, 2024
@wxiaoguang
Copy link
Contributor

I would say the UI looks more ugly than before, these "installing" texts are just redundancy, and the sizes (font/image) are uncoordinated.

Since there is already an animation, I do not see why adding more sentences makes sense.

@kerwin612
Copy link
Member Author

I would say the UI looks more ugly than before, these "installing" texts are just redundancy, and the sizes (font/image) are uncoordinated.

Since there is already an animation, I do not see why adding more sentences makes sense.

image
Title, animation, description; not conflicting...

@wxiaoguang
Copy link
Contributor

Title, animation, description; not conflicting...

Your sample screenshot is well-designed and good-looking. And it does provide more details about each step, not just keep saying "installing" again and again.

Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the short fix.

templates/post-install.tmpl Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 27, 2024
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it doesn't look good to me

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Dec 27, 2024
@techknowlogick
Copy link
Member

I apologize if this is getting into yak-shaving territory.

I think having both "installing" and "please wait" is important, as even though there is the animation, for screen-readers they won't see that animation. This way, they'll know there is something happening that they need to wait for.

@wxiaoguang
Copy link
Contributor

I apologize if this is getting into yak-shaving territory.

I think having both "installing" and "please wait" is important, as even though there is the animation, for screen-readers they won't see that animation. This way, they'll know there is something happening that they need to wait for.

At least, the page should be well-designed and good-looking. But not adding more and more uncoordinated elements.

Have you ever seen other websites or apps use such layout ? Small font, large icon, small font, keep repeating "installing", and visually misaligned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged modifies/templates This PR modifies the template files modifies/translation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants