-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize the installation page #32994
base: main
Are you sure you want to change the base?
Conversation
Could you post a screenshot? |
I would say the UI looks more ugly than before, these "installing" texts are just redundancy, and the sizes (font/image) are uncoordinated. Since there is already an animation, I do not see why adding more sentences makes sense. |
Your sample screenshot is well-designed and good-looking. And it does provide more details about each step, not just keep saying "installing" again and again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the short fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it doesn't look good to me
I apologize if this is getting into yak-shaving territory. I think having both "installing" and "please wait" is important, as even though there is the animation, for screen-readers they won't see that animation. This way, they'll know there is something happening that they need to wait for. |
At least, the page should be well-designed and good-looking. But not adding more and more uncoordinated elements. Have you ever seen other websites or apps use such layout ? Small font, large icon, small font, keep repeating "installing", and visually misaligned? |
No description provided.