Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always show assignees on right #33006

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

always show assignees on right #33006

wants to merge 1 commit into from
+26 −26

Conversation

metiftikci
Copy link
Contributor

Before

old_issue_list

After

new_issue_list

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 27, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 27, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Dec 27, 2024
@lunny lunny added this to the 1.24.0 milestone Dec 27, 2024
wxiaoguang
wxiaoguang previously approved these changes Dec 27, 2024
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 27, 2024
@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 27, 2024
@wxiaoguang
Copy link
Contributor

Oh wait, it make mobile view worse .......

@metiftikci
Copy link
Contributor Author

what is the width you are checking?

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Dec 27, 2024 •
edited
Loading

"width": main stream phone screen width, provided by Chrome devtools.

Old:

image

New:

image

@metiftikci
Copy link
Contributor Author

actually that does not looks bad to me 😆 what do you suggest?

@wxiaoguang
Copy link
Contributor

actually that does not looks bad to me 😆 what do you suggest?

I think on narrow screen, it's better to wrap the title and the right part (assignee) in one line ..... I recalled an old issue : Improve flex-item overflow #31404 (31404 is still draft but the screenshot looks better)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/templates This PR modifies the template files size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@metiftikci @wxiaoguang @lunny @GiteaBot