Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix scoped label ui when contains emoji #33007

Merged
merged 2 commits into from
Dec 28, 2024
Merged

fix scoped label ui when contains emoji #33007

merged 2 commits into from
Dec 28, 2024

Conversation

metiftikci
Copy link
Contributor

Before

old_label

After

new_label

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 27, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 27, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 27, 2024
@lunny lunny added the type/bug label Dec 27, 2024
@lunny
Copy link
Member

lunny commented Dec 27, 2024

Should this be backported to v1.23?

@metiftikci
Copy link
Contributor Author

@lunny yes

@lunny lunny added the backport/v1.23 This PR should be backported to Gitea 1.23 label Dec 27, 2024
@lunny lunny added this to the 1.24.0 milestone Dec 27, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 27, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 28, 2024
@lunny lunny enabled auto-merge (squash) December 28, 2024 00:53
@lunny lunny merged commit 254314b into go-gitea:main Dec 28, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 28, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 28, 2024
@metiftikci @GiteaBot
fix scoped label ui when contains emoji (go-gitea#33007)
9fb0cf8 
### Before

![old_label](https://github.com/user-attachments/assets/2211f711-613a-4ed4-90fd-8ff6ab0700f5)

### After

![new_label](https://github.com/user-attachments/assets/ecbc89da-7f77-44d0-8ce9-ba51b67421e5)
@GiteaBot GiteaBot mentioned this pull request Dec 28, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Dec 28, 2024
wxiaoguang pushed a commit that referenced this pull request Dec 28, 2024
@GiteaBot @metiftikci
fix scoped label ui when contains emoji (#33007) (#33014)
f27128b 
Backport #33007 by metiftikci

Co-authored-by: metiftikci <metiftikci@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvh delvh delvh approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@metiftikci @lunny @wxiaoguang @delvh @GiteaBot