Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and/or comment some legacy CSS problems #33015

Merged
merged 5 commits into from
Dec 28, 2024
Merged

Fix and/or comment some legacy CSS problems #33015

merged 5 commits into from
Dec 28, 2024
+13 −27

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Dec 28, 2024 •
edited
Loading

  1. using tw-overflow-visible is not good but it is still needed
  2. there is no shortsha, just use ui sha label
  3. some .explore .secondary-nav styles do not have effects
  4. there is no .ui.popup anymore
  5. move @tailwind utilities; to the end since our helpers do not conflict with it
  6. quick fix Admin tip cover the dropdown icon #32991

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 28, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 28, 2024
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 28, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Dec 28, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 28, 2024
delvh
delvh approved these changes Dec 28, 2024
View reviewed changes
templates/repo/branch/list.tmpl Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 28, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) December 28, 2024 11:28
@wxiaoguang wxiaoguang merged commit a92f505 into go-gitea:main Dec 28, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Dec 28, 2024
@wxiaoguang wxiaoguang deleted the fix-css branch December 28, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Admin tip cover the dropdown icon
4 participants
@wxiaoguang @lunny @delvh @GiteaBot