Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken error messages caused by #45 #49

Open
bogdandrutu opened this issue Oct 12, 2024 · 2 comments
Open

Broken error messages caused by #45 #49

bogdandrutu opened this issue Oct 12, 2024 · 2 comments

Comments

@bogdandrutu
Copy link

See open-telemetry/opentelemetry-collector#11427, I had to do this to be able to upgrade to v2.2.1.

This is most likely caused by b0e65b3#diff-7276b880a688d3af79f0a7b18e13df164968ac39766a475f3c91f9c445558e8fR803

/cc @yurishkuro

@bogdandrutu bogdandrutu changed the title Broken error messages cause by Broken error messages caused by Oct 12, 2024
@bogdandrutu bogdandrutu changed the title Broken error messages caused by Broken error messages caused by #45 Oct 12, 2024
@sagikazarmark
Copy link
Member

@yurishkuro looking at that change, I'm not quite sure why it's necessary. Can you clarify? Is it because of the nil value use case?

@yurishkuro
Copy link

yes, the original error message did not work under all conditions (it would panic)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants