[enhancement] Add check for reflect.Value in ComposeDecodeHookFunc
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
yurishkuro
approved these changes
Nov 17, 2024
There was a problem hiding this comment.
+1, this should address my original use case without introducing a new hook API (which I still thing is a worthy thing to do, e.g. there is a similar issue #21)
|
@sagikazarmark Are you able to take a look at this? |
|
Thanks @mahadzaryab1! Can you verify that the latest main works for your use cases in OTEL? Also, I wouldn't mind fixing #49 before cutting a new release, I'm just not sure yet what the right fix is, but I suspect simply reverting the error message should work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to #37. In this PR, we add a check to
ComposeDecodeHookFuncto see if the data obtained from the hook is of typereflect.Value. If it is, then we don't make an additionalreflect.ValueOfcall. This allows us to not drop into the "value" space which is helpful when decoding nil values as they panic when going from reflect.Value to a value via.Interface().