Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow pass nullptr Object * from godot core #992

Closed
wants to merge 1 commit into from
Closed

Allow pass nullptr Object * from godot core #992

wants to merge 1 commit into from

Conversation

Daylily-Zeleen
Copy link
Contributor

@Daylily-Zeleen Daylily-Zeleen commented Jan 11, 2023 •
edited
Loading

Fix #946 .
Fix #886 .

Becacuse pass nullptr from godot core only happen in _parse_property(), so I have not handle const Object *.

@Daylily-Zeleen Daylily-Zeleen marked this pull request as ready for review January 11, 2023 16:24
@Daylily-Zeleen Daylily-Zeleen requested a review from a team as a code owner January 11, 2023 16:24
@Daylily-Zeleen Daylily-Zeleen mentioned this pull request Jan 12, 2023
Open
@Daylily-Zeleen Daylily-Zeleen force-pushed the daylily-zeleen/allow_pass_nullptr_from_godot_core branch from 79afb44 to c25d689 Compare April 22, 2023 05:49
@Daylily-Zeleen
Copy link
Contributor Author

Already handled by pull requests which relate to #1123.

@Daylily-Zeleen Daylily-Zeleen deleted the daylily-zeleen/allow_pass_nullptr_from_godot_core branch June 26, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
archived
Projects
None yet
Milestone
No milestone
2 participants
@Daylily-Zeleen @aaronfranke