delay: base64 encode function arguments #279
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The delay package uses gob to encode the function arguments. However, gob is a binary encoding, and recent dev_appserver.py versions expect the request body to be valid UTF-8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for https://issuetracker.google.com/issues/225584760. It works in my limited testing, but it certainly has implications on request sizes, etc.
The delay package uses gob to encode the function arguments. However,
gob is a binary encoding, and recent dev_appserver.py versions expect
the request body to be valid UTF-8.
Note that this is for the v1 API.