cmd/go/internal/work: allow @ character in some -Wl, linker flags on darwin #70939

t0rr3sp3dr0 · 2024-12-20T07:46:49Z

The GNU linker interprets @file as "read command-line options from file".
Thus, we forbid values starting with @ on linker flags. However, this
causes a problem when targeting Darwin. @executable_path, @loader_path, and
@rpath are special values used in Mach-O to change the library search path
and can be used in conjunction with the -install_name and -rpath linker
flags. Since the GNU linker does not support Mach-O, targeting Darwin
implies not using the GNU linker. Therefore, we allow @ in the linker flags
if and only if cfg.Goos == "darwin".

Fixes #40559

gopherbot · 2024-12-20T07:57:15Z

This PR (HEAD: f72e4f8) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/638075.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-12-21T02:30:41Z

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-21T04:09:02Z

Message from Pedro Tôrres:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

Signed-off-by: Pedro Tôrres <t0rr3sp3dr0@gmail.com>

gopherbot · 2024-12-21T04:32:40Z

This PR (HEAD: 8223b5c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/638075.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-12-21T04:40:30Z

Message from Pedro Tôrres:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-21T23:41:33Z

Message from Ian Lance Taylor:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-21T23:41:34Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-21T23:29:10Z","revision":"c5f2492f50988dcf4d493ce61e2750b531059351"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-21T23:48:58Z

Message from Ian Lance Taylor:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-21T23:48:58Z

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64-newinliner has failed with summary (view all results):

go on master (change 638075)

Build or test failure, click here for results.

To reproduce, try gomote repro 8727899161809428689.

Additional links for debugging:

Output for go tool dist test -json [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-21T23:48:58Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

Signed-off-by: Pedro Tôrres <t0rr3sp3dr0@gmail.com>

gopherbot · 2024-12-22T05:02:17Z

This PR (HEAD: 25d06ff) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/638075.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-12-22T05:40:17Z

Message from Pedro Tôrres:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-22T07:44:38Z

Message from Ian Lance Taylor:

Patch Set 4: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-22T07:44:39Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-22T07:30:26Z","revision":"df8bd99aab450de7c0b5077a8192b610789150e2"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-22T07:59:43Z

Message from Ian Lance Taylor:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-22T07:59:44Z

Message from Go LUCI:

Patch Set 4:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-22T07:59:44Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-22T19:55:56Z

Message from Pedro Tôrres:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-23T00:07:23Z

Message from Ian Lance Taylor:

Patch Set 4: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-23T00:07:23Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-22T23:57:09Z","revision":"df8bd99aab450de7c0b5077a8192b610789150e2"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-23T00:07:24Z

Message from Ian Lance Taylor:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-23T00:07:24Z

Message from Go LUCI:

Patch Set 4:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

go on master (change 638075)
tools on master (commit ebeac1b)

Build or test failure, click here for results.

To reproduce, try gomote repro 8727806804236865889.

Additional links for debugging:

Output for test golang.org/x/tools/gopls module

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-23T00:07:25Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-23T20:35:09Z

Message from Pedro Tôrres:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-23T21:30:00Z

Message from Ian Lance Taylor:

Patch Set 5: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-23T21:37:51Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-23T21:20:55Z","revision":"f0363c65898d98e1d545adfb47cdec5d119b708f"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-23T21:37:51Z

Message from Ian Lance Taylor:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-23T21:45:36Z

Message from Ian Lance Taylor:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-23T21:45:36Z

Message from Go LUCI:

Patch Set 5:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-windows-386 has failed with summary (view all results):

go on master (change 638075)

Build or test failure, click here for results.

To reproduce, try gomote repro 8727726037820195825.

Additional links for debugging:

Output for go tool dist test -json [shard 4]

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-23T21:45:37Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-23T22:17:09Z

Message from Ian Lance Taylor:

Patch Set 5: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-23T22:17:10Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-23T22:04:13Z","revision":"f0363c65898d98e1d545adfb47cdec5d119b708f"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-23T22:32:36Z

Message from Ian Lance Taylor:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-23T22:32:37Z

Message from Go LUCI:

Patch Set 5:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-23T22:32:37Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-23T23:40:55Z

Message from Ian Lance Taylor:

Patch Set 5: Auto-Submit+1 Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-23T23:49:03Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-23T23:31:40Z","revision":"f0363c65898d98e1d545adfb47cdec5d119b708f"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-24T00:05:24Z

Message from Ian Lance Taylor:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-24T00:05:24Z

Message from Go LUCI:

Patch Set 5:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-26T16:03:23Z

Message from Cherry Mui:

Patch Set 5: Code-Review+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

Signed-off-by: Pedro Tôrres <t0rr3sp3dr0@gmail.com>

gopherbot · 2024-12-27T07:21:56Z

This PR (HEAD: 2b81dcd) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/638075.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-12-27T07:30:16Z

Message from Pedro Tôrres:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-27T07:30:17Z

Message from Pedro Tôrres:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-27T07:48:35Z

Message from Ian Lance Taylor:

Patch Set 6: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-27T07:56:32Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-27T07:41:32Z","revision":"cee74e314b18e639ea514aed8a51b05f0d0fba88"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-27T08:12:51Z

Message from Ian Lance Taylor:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-27T08:12:51Z

Message from Go LUCI:

Patch Set 6:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-27T08:12:52Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

@rpath

…darwin The GNU linker interprets @file as "read command-line options from file". Thus, we forbid values starting with @ on linker flags. However, this causes a problem when targeting Darwin. @executable_path, @loader_path, and @rpath are special values used in Mach-O to change the library search path and can be used in conjunction with the -install_name and -rpath linker flags. Since the GNU linker does not support Mach-O, targeting Darwin implies not using the GNU linker. Therefore, we allow @ in the linker flags if and only if cfg.Goos == "darwin". Fixes #40559 Change-Id: I0896758f0835e444ea0d501ea3fd8423cff97a27 GitHub-Last-Rev: 2b81dcd GitHub-Pull-Request: #70939 Reviewed-on: https://go-review.googlesource.com/c/go/+/638075 Auto-Submit: Ian Lance Taylor <iant@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

gopherbot · 2024-12-27T20:44:47Z

This PR is being closed because golang.org/cl/638075 has been merged.

allow @ in -Wl, linker flags on darwin

f72e4f8

restrict -Wl, linker flags with @ on darwin

8223b5c

Signed-off-by: Pedro Tôrres <t0rr3sp3dr0@gmail.com>

fix tests

25d06ff

Signed-off-by: Pedro Tôrres <t0rr3sp3dr0@gmail.com>

whitelist ios

2b81dcd

Signed-off-by: Pedro Tôrres <t0rr3sp3dr0@gmail.com>

gopherbot closed this Dec 27, 2024

cmd/go/internal/work: allow @ character in some -Wl, linker flags on darwin #70939

cmd/go/internal/work: allow @ character in some -Wl, linker flags on darwin #70939

Conversation

t0rr3sp3dr0 commented Dec 20, 2024 • edited Loading

gopherbot commented Dec 20, 2024

gopherbot commented Dec 21, 2024

gopherbot commented Dec 21, 2024

gopherbot commented Dec 21, 2024

gopherbot commented Dec 21, 2024

gopherbot commented Dec 21, 2024

gopherbot commented Dec 21, 2024

gopherbot commented Dec 21, 2024

gopherbot commented Dec 21, 2024

gopherbot commented Dec 21, 2024

gopherbot commented Dec 22, 2024

gopherbot commented Dec 22, 2024

gopherbot commented Dec 22, 2024

gopherbot commented Dec 22, 2024

gopherbot commented Dec 22, 2024

gopherbot commented Dec 22, 2024

gopherbot commented Dec 22, 2024

gopherbot commented Dec 22, 2024

gopherbot commented Dec 23, 2024

gopherbot commented Dec 23, 2024

gopherbot commented Dec 23, 2024

gopherbot commented Dec 23, 2024

gopherbot commented Dec 23, 2024

gopherbot commented Dec 23, 2024

gopherbot commented Dec 23, 2024

gopherbot commented Dec 23, 2024

gopherbot commented Dec 23, 2024

gopherbot commented Dec 23, 2024

gopherbot commented Dec 23, 2024

gopherbot commented Dec 23, 2024

gopherbot commented Dec 23, 2024

gopherbot commented Dec 23, 2024

gopherbot commented Dec 23, 2024

gopherbot commented Dec 23, 2024

gopherbot commented Dec 23, 2024

gopherbot commented Dec 23, 2024

gopherbot commented Dec 23, 2024

gopherbot commented Dec 24, 2024

gopherbot commented Dec 24, 2024

gopherbot commented Dec 26, 2024

gopherbot commented Dec 27, 2024

gopherbot commented Dec 27, 2024

gopherbot commented Dec 27, 2024

gopherbot commented Dec 27, 2024

gopherbot commented Dec 27, 2024

gopherbot commented Dec 27, 2024

gopherbot commented Dec 27, 2024

gopherbot commented Dec 27, 2024

gopherbot commented Dec 27, 2024

t0rr3sp3dr0 commented Dec 20, 2024 •

edited

Loading