-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
text/template: document function name rules and refactor goodName #70943
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: 4b4c230) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/637697. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/637697. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/637697. |
Message from Rob Pike: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/637697. |
Message from Крум Цанев: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/637697. |
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/637697. |
Message from Крум Цанев: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/637697. |
Message from Ian Lance Taylor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/637697. |
This PR (HEAD: f869baa) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/637697. Important tips:
|
This PR (HEAD: b8e5aa3) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/637697. Important tips:
|
func goodName(name string) bool
in text/template
Message from Ian Lance Taylor: Patch Set 6: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/637697. |
Message from Go LUCI: Patch Set 6: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-12-22T23:49:29Z","revision":"562aa4345a824ecc5b1117f2448d9ed4c7958cc4"} Please don’t reply on this GitHub thread. Visit golang.org/cl/637697. |
Message from Ian Lance Taylor: Patch Set 6: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/637697. |
Message from Go LUCI: Patch Set 6: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/637697. |
Message from Go LUCI: Patch Set 6: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/637697. |
Message from Rob Pike: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/637697. |
Message from Крум Цанев: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/637697. |
This change enhances the documentation by specifying permissible function names in the
Funcs
function of bothtext/template
andhtml/template
.Additionally, the
goodName
function has been refactored to improve readability and maintainability, ensuring it allows only letters, underscores, or digits, with the constraint that a digit cannot be the initial character.While the primary modifications are in
text/template
, they also impacthtml/template
, as it utilizesgoodName
internally.