New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/printer: predict the position of the '.' in SelectorExpr #70982

Open

mateusz834 wants to merge 1 commit into golang:master from mateusz834:printer-SelectorExpr-no-dot-pos-workaround

Member

mateusz834 commented Dec 24, 2024 •

edited

Loading

Workaround for issue #70978, see the issue for more details.

Fixes #70978


          go/printer: predict the position of the '.' in SelectorExpr

ff6d2eb

Workarorund for issue golang#70978, see the same issue for more details.

Fixes golang#70978

Change-Id: I7934d51af0679ac6fc10128d77001b0092bd7392

Contributor

gopherbot commented Dec 24, 2024

This PR (HEAD: ff6d2eb) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/638636.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Contributor

gopherbot commented Dec 24, 2024

Message from Mateusz Poliwczak:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/638636.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 24, 2024

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-24T13:33:42Z","revision":"5883e33680aece5898cd455ac86e667f5b88da1c"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/638636.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 24, 2024

Message from Mateusz Poliwczak:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/638636.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 24, 2024

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/638636.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 24, 2024

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/638636.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet