New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: Adding function to setup server #3

Draft

laches1sm wants to merge 3 commits into golang:master from laches1sm:factoring_out_server_creation

+29 −15

laches1sm commented Jul 8, 2020

What changes does this PR bring?

This PR implements a new function, CreateAndInstallServer(), which refactors duplicated parts of code surrounding the creation and installation of routes and places it into this function.
For now, I've placed this function within the server.go - please tell me if there's a better place for it!

Thank you all very much in advance for your feedback :D

laches1sm added 3 commits

July 8, 2020 11:10


          Adding new function to factor out server creation, and also added it …

96f0843

…to problematic areas of the tests


          Removed TODO comment

28c9610


          Removed rouge paren

904b871

googlebot added the cla: yes label

Contributor

gopherbot commented Jul 8, 2020

This PR (HEAD: 904b871) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/pkgsite/+/241458 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Jul 8, 2020

Message from Jonathan Amsterdam:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/241458.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 8, 2020

Message from Rebecca Martin:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/241458.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 8, 2020

Message from Julie Qiu:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/241458.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 8, 2020

Message from Rebecca Martin:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/241458.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 8, 2020

Message from Julie Qiu:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/241458.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 8, 2020

Message from Rebecca Martin:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/241458.
After addressing review feedback, remember to publish your drafts!

laches1sm marked this pull request as draft

July 8, 2020 14:06

Contributor

gopherbot commented Jul 8, 2020

Message from Jonathan Amsterdam:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/241458.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 8, 2020

Message from Rebecca Martin:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/241458.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 8, 2020

Message from Jonathan Amsterdam:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/241458.
After addressing review feedback, remember to publish your drafts!

Shellterreur commented Dec 7, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels