Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/goTest: fix multifile suite test fails to debug #2415

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

src/goTest: fix multifile suite test fails to debug #2415

wants to merge 1 commit into from
+97 −16

Conversation

nirhaas
Copy link
Contributor

@nirhaas nirhaas commented Aug 15, 2022

Collect a packages suites and maps their name with the caller function. This mapping is used to fix a bug where vscode-go was formatting wrong arguments for dlv (-test.run).

Fixes #2414

@gopherbot
Copy link
Collaborator

This PR (HEAD: 1a9b381) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/424094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Suzy Mueller:

Patch Set 1:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@nirhaas nirhaas changed the title fix multifile suite test fails to debug src/goTest: fix multifile suite test fails to debug Aug 18, 2022
@nirhaas nirhaas force-pushed the nhaas/fix_debug_multifile_test_suite branch from 1a9b381 to 1ab2947 Compare August 18, 2022 19:11
@gopherbot
Copy link
Collaborator

This PR (HEAD: 1ab2947) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/424094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Nir Haas:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Suzy Mueller:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Nir Haas:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Nir Haas:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Suzy Mueller:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Suzy Mueller:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@nirhaas nirhaas force-pushed the nhaas/fix_debug_multifile_test_suite branch from 1ab2947 to c97e661 Compare September 2, 2022 18:59
@gopherbot
Copy link
Collaborator

This PR (HEAD: c97e661) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/424094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@nirhaas nirhaas force-pushed the nhaas/fix_debug_multifile_test_suite branch from c97e661 to 09deeca Compare September 2, 2022 19:09
@gopherbot
Copy link
Collaborator

This PR (HEAD: 09deeca) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/424094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Nir Haas:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Nir Haas:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Suzy Mueller:

Patch Set 4: Code-Review+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Suzy Mueller:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 4: Auto-Submit+1 Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 4: Run-TryBot+1 -Auto-Submit

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 4:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/16780e7b-5957-419f-96ae-b57ac3fcc7c1

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 4: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/16780e7b-5957-419f-96ae-b57ac3fcc7c1

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Jamal Carvalho:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@nirhaas nirhaas force-pushed the nhaas/fix_debug_multifile_test_suite branch from 09deeca to 19b8cd4 Compare September 14, 2022 16:57
@gopherbot
Copy link
Collaborator

This PR (HEAD: 19b8cd4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/424094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Nir Haas:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Jamal Carvalho:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 5:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/a26112ed-f26d-470f-8b28-d0868baa3efa

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 5: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/a26112ed-f26d-470f-8b28-d0868baa3efa

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Nir Haas:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Jamal Carvalho:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 5:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/0cf44da8-6f10-428d-868b-1a378fe664c9

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 5: TryBot-Result+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/0cf44da8-6f10-428d-868b-1a378fe664c9

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Nir Haas:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@divmgl divmgl mentioned this pull request Nov 9, 2022
Closed
@gopherbot
Copy link
Collaborator

Message from Morten Gerdes:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 5: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

@Cr4zySheep Cr4zySheep mentioned this pull request Jan 14, 2024
Closed
gopherbot pushed a commit that referenced this pull request Feb 12, 2024
@Cr4zySheep @gopherbot
src/goTest: fix multifile suite test fails to debug
7bfbcaf 
I have resumed the pull request #2415 and added the missing tests.

Here is the original description:

Collect a packages suites and maps their name with the caller function. This mapping is
used to fix a bug where vscode-go was formatting wrong arguments for dlv (-test.run).

Fixes #2414

Change-Id: Id6ac5d153fa1dbcdb7591b2bd0ee78bfa95686c6
GitHub-Last-Rev: 0fa9525
GitHub-Pull-Request: #3128
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/555676
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to debug a suite test that is in a different file than the caller test
2 participants
@nirhaas @gopherbot