-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_content/tour/static/css/app.css: fix hidden horizontal scrollbar for long outputs #283
base: master
Are you sure you want to change the base?
Conversation
The calc(100% - 52px) corrects for the 32px that the .output element sticks out below the bottom of the page, and 20px for for the 10px padding that all pre tags have on the top and bottom. If this isn't corrected for then the vertical scrollbar is rendered below the bottom of the page.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: a6844bb) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/website/+/584855. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/584855. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/584855. |
Fixed root cause of issue: the `#explorer + div` element was sticking out 32px below the page, not anymore. `.output > pre` now uses box-sizing so that max-height 100% will always work regardless of any specific padding.
This PR (HEAD: 8a9aabc) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/website/+/584855. Important tips:
|
change is now minimal
This PR (HEAD: 6f7ecd3) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/website/+/584855. Important tips:
|
Message from Sanian Creations: Patch Set 6: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/584855. |
Message from Sanian Creations: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/584855. |
Message from Sanian Creations: Patch Set 6: -Code-Review Please don’t reply on this GitHub thread. Visit golang.org/cl/584855. |
This fixes a problem where long outputs go off the screen and the
horizontal scrollbar is not visible (shift-scrolling is currently
possible but this isn't communicated to users), an example is the long
error message when running https://go.dev/tour/methods/9
calc(100% - 32px)
fixes that this element stuck out 32px below thebottom of the page (which hid the scrollbar that was there).
min-width: min-content
fixes that this element would have its textoverflow off to the right.
This is a cosmetic fix, there is no bug report.