Combinatorialize tarpc feature tests. #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the CI github workflow, in the job test-with-features, make a
separate matrix dimension for each Cargo feature to enable. Github
Actions should combine these features, so that we get more test coverage
of different feature enablements.
This also introduces a minor breaking change by renaming
serde_transport::{tcp,unix}::Connect to {Tcp,Unix}Connect.
Rationale: enabling all combinations actually revealed a compile_fail
error that only arises when certain combinations of features are
enabled! In the serde_transport module, there are two submodules, tcp
and unix, which each provide a Connect type. When only one of the
tcp/unix features is enabled, there is a unique path to the Connect
type, and the name gets shortened in compile error messages. When both
features are enabled, there is no longer a unique path to the Connect
type, and the compile error messages print the full path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the CI github workflow, in the job test-with-features, make a separate matrix dimension for each Cargo feature to enable. Github Actions should combine these features, so that we get more test coverage of different feature enablements.
This also introduces a minor breaking change by renaming serde_transport::{tcp,unix}::Connect to {Tcp,Unix}Connect.
Rationale: enabling all combinations actually revealed a compile_fail error that only arises when certain combinations of features are enabled! In the serde_transport module, there are two submodules, tcp and unix, which each provide a Connect type. When only one of the tcp/unix features is enabled, there is a unique path to the Connect type, and the name gets shortened in compile error messages. When both features are enabled, there is no longer a unique path to the Connect type, and the compile error messages print the full path.