Merge pull request #630 from govau/develop

aria-selected must be set to false on the unselected tabs -> master
govau · Jul 21, 2019 · 1d674d8 · 1d674d8
2 parents 2f23340 + 7e81f0f
commit 1d674d8
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/js/footer/070-tabs.js b/src/js/footer/070-tabs.js
@@ -10,7 +10,7 @@ AddEvent( tabItems, 'click', function( event, $this ) {
 
 	for( var i = 0; i < currentTabItems.length; i++ ) {
 		RemoveClass( currentTabItems[ i ], 'tab-item--active' );
-		currentTabItems[ i ].removeAttribute( 'aria-selected' );
+		currentTabItems[ i ].setAttribute( 'aria-selected', 'false' );
 		currentTabItems[ i ].setAttribute( 'tabindex', '1' );
 	}
 
@@ -40,6 +40,9 @@ var InitialiseTabs = function( tabs ) {
 		if( HasClass( tabs[ i ], 'tab-item--active' ) ){
 			tabs[ i ].setAttribute( 'aria-selected', 'true' );
 		}
+		else  {
+			tabs[ i ].setAttribute( 'aria-selected', 'false' );
+		}
 	}
 };