Add texture_builtin_notes.md #4127
Conversation
|
I think this is a valuable thing to have in the repo. I'll let others weigh in on whether it belongs here or in |
| ------------------------------------------------------------------------------------------------------------ | ||
| ## gpu:Intel Comet Lake S UHD Graphics 630 (8086:9bc5-31.0.101.2127) | ||
| ## os:Windows-10 | ||
| ## affected: `textureGather` with cube and cube-arrays. |
There was a problem hiding this comment.
nit: confusing in the rendered version because it looks like there are two empty sections. Maybe use
## A<br>B<br>Cor just put the details inside the section body
| # Texture Builtin Notes | ||
|
|
||
| These are known failures for various GPUs. If you find more, please add to this list so developers | ||
| can be aware what does and does not work. |
There was a problem hiding this comment.
If we want this to be discoverable by developers then maybe it should be on some github wiki or something. I'm not sure where is a good place for it.
Otherwise having it here is fine, though I'd add a mention of this file in one of the READMEs or test description files so it's not "unreferenced" from the test suite.
There was a problem hiding this comment.
I started a wiki here
https://github.com/gpuweb/gpuweb/wiki/Texture-Builtins-Issues
I thought about making one page per issue and linking them from the that page. Or I can just past them all in that one page.
There was a problem hiding this comment.
Personally I think one page is better, github wikis don't really handle having many pages that well.
As for this PR, it'll still useful to add a link to that wiki page in one of the readmes/descriptions.
There was a problem hiding this comment.
I posted the issue is the wiki but unfortunately it's not really readable as github gives the wiki a maximum width. Maybe the wiki should just link to this and/or, maybe we could make it available at https://gpuweb.github.io/cts/standalone/src/webgpu/shader/execution/expression/call/builtin/texture_builtin_notes.md
There was a problem hiding this comment.
Ah, shame.
Linking is fine, we could have a gpuweb wiki page for errata, and link directly to the .md file in this repo. Don't think there's any need to make it work on gpuweb.github.io.
greggman
force-pushed
the
texture-builtin-notes
branch
from
296f897 to
139d565
Compare
I'm not sure this belongs here. Maybe it should be moved to
/docsor maybe it shouldn't exist in the repo at all. I thought about just making an issue in gpuweb/gpuweb/issues and posting each failure as a reply under that issue.Thoughts?