Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pro and enterprise main scripts #185

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Add pro and enterprise main scripts #185

merged 2 commits into from
Sep 27, 2023

Conversation

kminehart
Copy link
Collaborator

No description provided.

@kminehart kminehart requested a review from a team September 27, 2023 14:08
dsotirakis
dsotirakis reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@dsotirakis dsotirakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't cover the - vs ~ issue, yeah?

scripts/drone_publish_main.sh Outdated Show resolved Hide resolved
@kminehart
Copy link
Collaborator Author

kminehart commented Sep 27, 2023 •
edited
Loading

This PR doesn't cover the - vs ~ issue, yeah?

It does! That's handled in the move_scripts.go command at the end. I'll add a test for that that shows the ~ conversion

dsotirakis
dsotirakis approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@dsotirakis dsotirakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@kminehart kminehart merged commit 5bdea2f into main Sep 27, 2023
@kminehart kminehart deleted the add-pro-and-enterprise-main-builds branch September 27, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsotirakis dsotirakis dsotirakis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kminehart @dsotirakis