Publish each version only once on gcom publish #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kminehart
requested changes
Oct 3, 2023
containers/gcom_publish.go
Outdated
|
|
||
| _, err = d.Container().From("alpine/curl"). | ||
| WithSecretVariable("GCOM_API_KEY", apiKeySecret). | ||
| WithExec([]string{"/bin/sh", "-c", fmt.Sprintf(`curl -H "Content-Type: application/json" -H "Authorization: Bearer $GCOM_API_KEY" -d '%s' %s`, string(jsonVersionPayload), versionApiUrl)}). |
There was a problem hiding this comment.
If we're not redirecting stdout or anything this can just be []string{"curl", "-H', "Content-Type: application/json", etc.
There was a problem hiding this comment.
But we need the $GCOM_API_KEY would Dagger use the environment variable without calling /bin/sh ?
There was a problem hiding this comment.
yea pretty sure it will. try it!
containers/gcom_publish.go
Outdated
|
|
||
| // PublishGCOMPackage publishes a package to grafana.com. | ||
| func PublishGCOMPackage(ctx context.Context, d *dagger.Client, packagePayload *GCOMPackagePayload, opts *GCOMOpts, version string) error { | ||
| packagesApiUrl := fmt.Sprintf("%s/api/grafana/versions/%s/packages", opts.URL, version) |
There was a problem hiding this comment.
path.Join will get rid of the second / on "https://"
There was a problem hiding this comment.
use url.URL then if you're making a URL
There was a problem hiding this comment.
and path.Join to build the URL path
kminehart
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.