disposed Api services

granstel · Dec 14, 2023 · 592e514 · 592e514
1 parent 9648e16
commit 592e514
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/Dodo1000Bot.Api/DependencyModules/InternalServicesRegistration.cs b/Dodo1000Bot.Api/DependencyModules/InternalServicesRegistration.cs
@@ -9,12 +9,12 @@ internal static void AddInternalServices(this IServiceCollection services)
         {
             services.AddTransient<IConversationService, ConversationService>();
             services.AddTransient<INotificationsService, NotificationsService>();
-            services.AddTransient<UnitsService>();
+            services.AddScoped<UnitsService>();
             services.AddTransient<StatisticsService>();
             services.AddTransient<ICountriesService, CountriesService>();
             services.AddTransient<IUsersService, UsersService>();
-            services.AddTransient<IGlobalApiService, GlobalApiService>();
-            services.AddTransient<IPublicApiService, PublicApiService>();
+            services.AddScoped<IGlobalApiService, GlobalApiService>();
+            services.AddScoped<IPublicApiService, PublicApiService>();
 
             services.AddScoped<IDialogflowService, DialogflowService>();
         }

diff --git a/Dodo1000Bot.Services/GlobalApiService.cs b/Dodo1000Bot.Services/GlobalApiService.cs
@@ -9,7 +9,7 @@
 
 namespace Dodo1000Bot.Services;
 
-public class GlobalApiService : IGlobalApiService
+public class GlobalApiService : IGlobalApiService, IAsyncDisposable
 {
     private readonly ILogger<GlobalApiService> _log;
     private readonly IGlobalApiClient _globalApiClient;
@@ -98,4 +98,9 @@ private async Task UpdateSnapshot<TData>(string snapshotName, TData data, Cancel
 
         _memoryCache.Remove(snapshotName);
     }
+
+    public async ValueTask DisposeAsync()
+    {
+        await UpdateUnitsCountSnapshot(default);
+    }
 }
diff --git a/Dodo1000Bot.Services/PublicApiService.cs b/Dodo1000Bot.Services/PublicApiService.cs
@@ -14,7 +14,7 @@ namespace Dodo1000Bot.Services;
 
 using AllUnitsDictionary = Dictionary<string, Dictionary<Country, IEnumerable<UnitInfo>>>;
 
-public class PublicApiService : IPublicApiService
+public class PublicApiService : IPublicApiService, IAsyncDisposable
 {
     private readonly ILogger<PublicApiService> _log;
     private readonly IPublicApiClient _publicApiClient;
@@ -110,8 +110,8 @@ private async Task<AllUnitsDictionary> AllUnitsInternal(CancellationToken cancel
             foreach (var country in countriesOfBrand)
             {
                 var countryCode = country.Code;
-                var cacheName = GetUnitInfoOfBrandAtCountrySnapshotName(brand, countryCode);
 
+                var cacheName = GetUnitInfoOfBrandAtCountrySnapshotName(brand, countryCode);
                 var unitsInfoOfBrandAtCountry =
                     await _memoryCache.GetOrCreate(cacheName, _ => GetUnitsInfoOfBrandAtCountry(brand, countryCode, cancellationToken));
 
@@ -150,4 +150,9 @@ private async Task UpdateSnapshot<TData>(string snapshotName, TData data, Cancel
 
         _memoryCache.Remove(snapshotName);
     }
+
+    public async ValueTask DisposeAsync()
+    {
+        await UpdateAllUnitsSnapshot(default);
+    }
 }