Update guidelines to reflect the new Graphistry version #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aucahuasi
commented
Jul 12, 2024
•
aucahuasi
commented
- Update CUDA 11.5 to CUDA 11.8
- Update ubuntu 20.04 to ubuntu 22.04
- Update RAPIDS version (23.10) and new docker conventions (conda env).
- Update information about Azure Marketplace and NVIDIA GPUDirect Storage (GDS).
DataBoyTX
requested changes
Jul 12, 2024
There was a problem hiding this comment.
I think there's one file for the setup scripts that you might have overlooked:
graphistry-cli/docs/ubuntu_20_04_setup.sh
Line 299 in a6fcc76
but other than that, LGTM!
Good catch, thanks Thomas! Solved! |
lmeyerov
approved these changes
Jul 17, 2024
|
Looks good - let's merge when the new release goes out |
lmeyerov
reviewed
Jul 19, 2024
docs/azure_marketplace.md
Outdated
| Monitoring of this issue is ongoing to identify a permanent solution. Once Azure resolves this issue, GDS support will be re-enabled to take full advantage of its performance benefits. Customers will be informed of any updates or changes regarding this matter. | ||
|
|
||
| **Recommendations** | ||
| Users may override the default setting and enable GDS support manually by setting the environment variable in the `data/config/custom.env` file (a Docker Compose environment file). For example: `LIBCUDF_CUFILE_POLICY=ALWAYS`. |
There was a problem hiding this comment.
also add to azure.md that users most explicitly set LIBCUDF_CUFILE_POLICY=OFF as well, e.g., would happen if someone uses the tarball or AKS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.