Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Embed predict_links cuda #449

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tanmoyio
Copy link
Member

@tanmoyio tanmoyio commented Mar 7, 2023

No description provided.

setup.py Outdated Show resolved Hide resolved
Copy link
Contributor

@lmeyerov lmeyerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@silkspace for visibility

@silkspace silkspace changed the base branch from master to cleanup March 7, 2023 22:06
@silkspace
Copy link
Contributor

Looked green from Master, checking it from cleanup to check and docs are still failing. Please merge if you feel its worth it to master.

@tanmoyio
Copy link
Member Author

tanmoyio commented Mar 7, 2023

docs are failing because of cleanup-edits

@silkspace silkspace changed the base branch from cleanup to master March 7, 2023 22:31
@lmeyerov
Copy link
Contributor

lmeyerov commented Mar 7, 2023

yeah merging this to master if it works seems easier, then cleanup can merge it in

@silkspace
Copy link
Contributor

Yeah I just wanted to see if I moved Head to Cleanup (since thats on our docker for the preso). I moved it back to Master. Close it if you dare.

@tanmoyio tanmoyio force-pushed the fix_embed_pred_links_gpu branch from 260c02f to b8a4f5a Compare March 7, 2023 22:58
@lmeyerov
Copy link
Contributor

@tanmoyio is this in the merge branch already so can close this?

@lmeyerov lmeyerov added the WIP label Apr 30, 2023
@lmeyerov
Copy link
Contributor

@tanmoyio do we close? What is going on with this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants