-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor build of boreas-build/build.Dockerfile in boreas #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y0urself
reviewed
Sep 27, 2024
Co-authored-by: Jaspar Stach <jaspar.loechte@greenbone.net>
y0urself
reviewed
Sep 27, 2024
y0urself
previously approved these changes
Sep 30, 2024
y0urself
reviewed
Oct 1, 2024
y0urself
reviewed
Oct 1, 2024
Co-authored-by: Jaspar Stach <jaspar.loechte@greenbone.net>
Co-authored-by: Jaspar Stach <jaspar.loechte@greenbone.net>
…ssh-dev to general action
Ehm, do we even need a boreas image? The main functionality is within gvm-libs and I don't know if there is even a use case to use a docker image to test boreas-cli? |
nichtsfrei
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
We decided to do some refactoring for boreas.
container.yml should be replaced by push.yml which uses new https://github.com/greenbone/workflows/blob/main/.github/workflows/container-build-push-2nd-gen.yml workflow.
boreas-build build is not actively built and pushed to a docker registry.
But there are still workflows using that boreas-build image.
Therefore we gonna replace the boreas-build image with a manual step or composite action if used on multiple occasions.
Why:
Removing an unused/deprecated docker image is good.
Switching from build docker container to composite action worsens performance because cmds inside the dockerfile a run multiple times.
Switching to the new registry is at some point mandatory and therefore replacing container.yml improves maintenance.
How:
Let the CI run and find out if it fails.
Checklist: