-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD Doc API keys endpoints to documentation #383
base: master
Are you sure you want to change the base?
Conversation
More explicit supported python versions more explicit grist-checkout -> grist-core-checkout
: in array can be misinterpreted by some yaml parsers. Split enum in many line makes it easy
❌ Deploy Preview for grist-help-preview failed.
|
2 similar comments
❌ Deploy Preview for grist-help-preview failed.
|
❌ Deploy Preview for grist-help-preview failed.
|
Wait, will it really fix this issue? |
I'm ok that it's not perfect but I want to keep track the fact that this PR needs to be merge at the same time as the functional one.
Can't it be better to move it to gristlabs/grist-core and to pull it when doc is built ? @gristlabs people do you have an opinion over this ? |
I agree with @fflorent that the comment on the PR seems risky -- not sure it would actually close the issue in the other repo. Anyway, it would be helpful to have a clearer title and description for the PR, perhaps like "Add OpenAPI spec for the new Doc API keys endpoints in gristlabs/grist-core#579"? I also agree with @hexaltation suggestion to move |
Must be merge at the same time than gristlabs/grist-core#1115
for the new API endpoints can be accessible via console API.
Related to gristlabs/grist-core#579