Highlight types such as <type> in Python code blocks #38
+378
−370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, but adding another color is a bit much for my taste. |
Simply runs a regex replacement after highlight.js does the rest of the highlighting. As a consequence, it does not highlight strings such as `<class>` which contain a Python keyword. This is infrequent though.
jared-hughes
force-pushed
the
feature-highlight-types
branch
from
f408eb7 to
7b29bab
Compare
|
Same for my taste. This simple bolding looks much better. Also importantly, it preserves color within strings, which the green highlighting did not
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply runs a regex replacement after highlight.js does the rest of the
highlighting. As a consequence, it does not highlight strings such as
<class>which contain a Python keyword. This is relatively infrequentthough.