Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added phoenix_storybook to Framework Components #4892

Merged
merged 1 commit into from
Dec 15, 2024
Merged

added phoenix_storybook to Framework Components #4892

merged 1 commit into from
Dec 15, 2024
+1 −0

Conversation

cblavier
Copy link
Contributor

@cblavier cblavier commented Dec 12, 2024 •
edited
Loading

Thanks for your work 🙏

mariusbutuc
mariusbutuc reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@mariusbutuc mariusbutuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, even with the option to ignore whitespace changes, this diff is still so big!

Worth decoupling the addition from the rest of the formatting changes?

@cblavier
Copy link
Contributor Author

sorry about that, I didn't notice my formatter went crazy 🙃
I guess this is ok now?

@simonewebdesign simonewebdesign merged commit 2632067 into h4cc:master Dec 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusbutuc mariusbutuc mariusbutuc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cblavier @mariusbutuc @simonewebdesign