Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

226 new arena grand crevice - finished initital map #245

Merged
merged 13 commits into from
Oct 16, 2023

Conversation

CraZyB1336
Copy link
Contributor

@CraZyB1336 CraZyB1336 commented Oct 15, 2023

Grand Canyon map.

MainMenuController chooses a random map and continues with this map during the rounds. (In method ChangeScene)

GiantFan / SuperFan - Adds force to player upwards.

DeathBox - Invisible deathbox that eliminates the player.

Whats missing?:

  • Model design of the giant fan and superfan (I have the inital model finished just gotta UV-map it...)
  • More props.
  • Some faces clipping
  • Updating the model of the layers. make it more realistic (for instance hand placing each tile. It's a pain, but it looks nicer)

@CraZyB1336 CraZyB1336 linked an issue Oct 15, 2023 that may be closed by this pull request
3 tasks
@Fueredoriku Fueredoriku changed the base branch from main to dev October 15, 2023 18:39
Copy link
Contributor

@toberge toberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The map looks really good! The fans are a nice addition, even in their placeholder state.

I just have some comments regarding code style, and a question.

Assets/Scripts/Interactables/DeathTriggerScript.cs Outdated Show resolved Hide resolved
Assets/Scripts/Interactables/GiantFanController.cs Outdated Show resolved Hide resolved
Assets/Scripts/UI/MainMenuController.cs Outdated Show resolved Hide resolved
Assets/Scripts/Gamestate/MatchController.cs Show resolved Hide resolved
…ntFanController, Added texture to terrain, added additional directional light inside the map gameobject
@CraZyB1336 CraZyB1336 requested a review from toberge October 15, 2023 21:00
Copy link
Contributor

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Map looks GREAT! 😁👍

image
It would be nice if you made all the objects like closedGates and spawnpoints children of the "GrandCanyon2" object.
Also, I think we should have 2 more spawns for when there are 4 players.

I also have a couple of nitpicks regarding the lack of naming of some materials ("new material (0, 1, 2 and 3))" and the debug roundtimer length.
If you fix those I think it's good to go!

Assets/Materials/Gate/New Material 1.mat Outdated Show resolved Hide resolved
Assets/Scripts/Gamestate/MatchController.cs Outdated Show resolved Hide resolved
Assets/Textures/GrandCanyon/rocknormal.png Outdated Show resolved Hide resolved
Copy link
Contributor

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

@CraZyB1336 CraZyB1336 self-assigned this Oct 16, 2023
@Fueredoriku Fueredoriku linked an issue Oct 16, 2023 that may be closed by this pull request
3 tasks
@CraZyB1336 CraZyB1336 merged commit f030281 into dev Oct 16, 2023
1 check passed
@CraZyB1336 CraZyB1336 deleted the 226-new-arena-grand-crevice branch October 16, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

Grand crevice modeling New arena: Grand crevice
3 participants