Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auction polish #281

Merged
merged 5 commits into from
Nov 12, 2023
Merged

Auction polish #281

merged 5 commits into from
Nov 12, 2023

Conversation

Fueredoriku
Copy link
Contributor

@Fueredoriku Fueredoriku commented Nov 9, 2023

  • Updated dynamic BiddingPlatform material to better showcase leading player color
    • Resized text elements for better readability
    • Made descriptions collapse if no players are stending on platforms
  • Made BiddingPlayers have a pulsating X over their chip count if they can't afford to bid
    newPlatforms

@Fueredoriku Fueredoriku self-assigned this Nov 9, 2023
@Fueredoriku Fueredoriku marked this pull request as ready for review November 10, 2023 02:04
Copy link
Contributor

@toberge toberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, I just have two suggestions (as mentioned on Discord):

  • We should have a (radial) progress bar for the time, as people have been confused about it
  • The description could be squished vertically to leave more space for other elements as the descriptions tend to be very short
    • This would leave more space for the timer

@Fueredoriku Fueredoriku requested a review from toberge November 11, 2023 21:34
Copy link
Contributor

@toberge toberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The radial timer works really well, nice addition!

I do notice one thing that's been around for a while: There's a substantial delay at the end of the bidding session where absolutely nothing happens, could we perhaps lower biddingEndDelay in the MatchManager prefab? To like just a second or two? 👉 👈

@Fueredoriku Fueredoriku merged commit 94daf66 into dev Nov 12, 2023
@Fueredoriku Fueredoriku deleted the feature/auction-polish branch November 12, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

Bidding Platform improvements Unable to bid on textbox of biddingplatform
2 participants