-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auction polish #281
Auction polish #281
Conversation
Fueredoriku
commented
Nov 9, 2023
•
edited
Loading
edited
- Updated dynamic BiddingPlatform material to better showcase leading player color
- Resized text elements for better readability
- Made descriptions collapse if no players are stending on platforms
- Made BiddingPlayers have a pulsating X over their chip count if they can't afford to bid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, I just have two suggestions (as mentioned on Discord):
- We should have a (radial) progress bar for the time, as people have been confused about it
- The description could be squished vertically to leave more space for other elements as the descriptions tend to be very short
- This would leave more space for the timer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The radial timer works really well, nice addition!
I do notice one thing that's been around for a while: There's a substantial delay at the end of the bidding session where absolutely nothing happens, could we perhaps lower biddingEndDelay in the MatchManager prefab? To like just a second or two? 👉 👈