Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize auction #660

Merged
merged 4 commits into from
May 26, 2024
Merged

Synchronize auction #660

merged 4 commits into from
May 26, 2024

Conversation

toberge
Copy link
Contributor

@toberge toberge commented May 25, 2024

in this PR we synchronize

  • Weapon construction readiness
  • Items assigned to bidding platforms
  • Placing bids
  • Receiving items
  • Loading screen

in this PR we leave these problems

  • The red cross shows up on the wrong bidding sign when a remote player can't bid (idk how)

@toberge toberge force-pushed the feature/network-auction branch 9 times, most recently from 60a8211 to 6bfa5ac Compare May 25, 2024 19:02
@toberge toberge force-pushed the feature/network-auction branch from 6bfa5ac to a4a6381 Compare May 25, 2024 19:03
@toberge toberge force-pushed the feature/network-auction branch 7 times, most recently from 63b85cc to 6ce3f26 Compare May 25, 2024 21:05
@toberge toberge marked this pull request as ready for review May 25, 2024 21:09
@toberge toberge force-pushed the feature/network-auction branch from 6ce3f26 to 77f95f9 Compare May 25, 2024 21:10
@toberge toberge requested a review from Fueredoriku May 25, 2024 21:10
Copy link
Contributor

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only have some small feedback here, as we have already moved on to #661

@toberge toberge merged commit 016943d into dev May 26, 2024
@toberge toberge deleted the feature/network-auction branch May 26, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

2 participants