Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github-handle variable #6099

Merged

Conversation

jlevot
Copy link
Member

@jlevot jlevot commented Jan 11, 2024

Fixes #5504

What changes did you make?

Add an empty github handle variable on 100 Automations project for Niven Prasad

Why did you make the changes (we will use this info to test)?

Eventually github-handle will replace the github and picture variables, reducing redundancy in the project file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jlevot-add-github-handle-variable-5504 gh-pages
git pull https://github.com/jlevot/website.git add-github-handle-variable-5504

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/jlevot/website/blob/add-github-handle-variable-5504/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jan 11, 2024
@jlevot jlevot self-assigned this Jan 12, 2024
@freaky4wrld freaky4wrld self-requested a review January 13, 2024 06:59
@freaky4wrld
Copy link
Member

Availability: Evenings
ETA: EOD 1/13/2024

@freaky4wrld
Copy link
Member

@jlevot thanks for taking up the issue, well the changes made by you are good to be merged, but before that I request some minor things

  • first please checkoff the box [ ] linked in the original issue
  • please replace There is no impacts on the web view, so it's not necessary to provide screenshots before/after with No visual changes
  • do remember to put the above line inside the Screenshot heading which you might have removed

Ping me when you are done and I'll approve it

@jlevot
Copy link
Member Author

jlevot commented Jan 13, 2024

@freaky4wrld Thank you for your review.

I have updated the PR body and checkoff the box linked in the original issue.

Copy link
Member

@freaky4wrld freaky4wrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks to merge, branches are correct, changes made are seen in local environment.... PR approved!!

@roslynwythe roslynwythe self-requested a review January 14, 2024 18:09
@kwangric kwangric self-requested a review January 15, 2024 20:41
@kwangric
Copy link
Member

Availability: Evening 1/15
ETA: EOD 1/15

Copy link
Member

@kwangric kwangric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branches are set up correctly. The PR is linked to the correct issue and the requested changes to the 100.automations.md file has been made. Everything still looks good in Docker, and the PR includes why the changes were made. Great work!

@t-will-gillis t-will-gillis merged commit f7d1cf7 into hackforla:gh-pages Jan 17, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new variable github-handle for member Niven Prasad in 100-automations.md
4 participants