Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added github-handle for Muhi-Dean Othman in 100-automations.md #6443

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

samuelusc
Copy link
Member

@samuelusc samuelusc commented Mar 10, 2024

Fixes #5507

What changes did you make?

  • I replace "- name: Muhi-Dean Othman" with "- name: Muhi-Dean Othman github-handle: " in _projects/100-automations.md

Why did you make the changes (we will use this info to test)?

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b samuelusc-add-github-handle-5507 gh-pages
git pull https://github.com/samuelusc/website-project.git add-github-handle-5507

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/samuelusc/website/blob/add-github-handle-5507/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) To Update ! No update has been provided size: 0.25pt Can be done in 0.5 to 1.5 hours labels Mar 10, 2024
@pdimaano pdimaano self-requested a review March 11, 2024 17:15
@pdimaano
Copy link
Member

ETA: 3/14/24
Availability: Weekday evenings

@ramitaarora ramitaarora self-requested a review March 11, 2024 19:45
@ramitaarora
Copy link
Member

ramitaarora commented Mar 11, 2024

ETA: Mar 13 Eod
Availability: 9am-2pm Weekdays

@Brayheart Brayheart requested review from Brayheart and removed request for Brayheart March 13, 2024 02:55
Copy link
Member

@pdimaano pdimaano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samuelusc Good job: The branches are correct and the issue is linked. The website still appears and works properly on my system on desktop, mobile and tablet. The correct file was updated with the requested information. Well done!

For future pull requests, if there are no visual changes to the website, you can remove the pre-placed text in the "Screenshots" section and instead write a statement such as "No visual changes to the website."

@github-actions github-actions bot removed the To Update ! No update has been provided label Mar 14, 2024
@samuelusc
Copy link
Member Author

Hi @pdimaano
Thank you for your feedback. I've updated pull request based on your comments.

Copy link
Member

@ramitaarora ramitaarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samuelusc This looks good! No visual changes to site, github handle variable has been added.

Thank you!

@freaky4wrld freaky4wrld merged commit 999543c into hackforla:gh-pages Mar 15, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new variable github-handle for member Muhi-Dean Othman in 100-automations.md
4 participants