HCK-9315: fix adding storage option to table only if defined (#157)

hackolade · Jan 2, 2025 · a79d4c9 · a79d4c9
1 parent 2272fb5
commit a79d4c9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/forward_engineering/ddlProvider/ddlHelpers/tableHelper.js b/forward_engineering/ddlProvider/ddlHelpers/tableHelper.js
@@ -1,12 +1,5 @@
 const _ = require('lodash');
-module.exports = ({
-	_,
-	getColumnsList,
-	checkAllKeysDeactivated,
-	commentIfDeactivated,
-	prepareName,
-	assignTemplates,
-}) => {
+module.exports = ({ getColumnsList, checkAllKeysDeactivated, commentIfDeactivated, prepareName, assignTemplates }) => {
 	const { getOptionsString } = require('./constraintHelper')({ _, prepareName });
 
 	const getTableType = ({
@@ -49,7 +42,7 @@ module.exports = ({
 			.filter(Boolean)
 			.join('');
 
-		return _.trim(statements) ? ` ${_.trim(statements)}` : '';
+		return _.trim(statements) ? `\n ${_.trim(statements)}` : '';
 	};
 
 	const getBlockChainClause =
@@ -78,7 +71,7 @@ module.exports = ({
 	const getStorage =
 		textTableProperties =>
 		({ organization, tablespace, logging }) => {
-			if (_.includes(textTableProperties, 'TABLESPACE')) {
+			if (!organization || _.includes(textTableProperties, 'TABLESPACE')) {
 				return '';
 			}
 

diff --git a/forward_engineering/ddlProvider/ddlProvider.js b/forward_engineering/ddlProvider/ddlProvider.js
@@ -69,7 +69,6 @@ module.exports = (baseProvider, options, app) => {
 		createKeyConstraint,
 		customPropertiesForForeignKey,
 	} = require('./ddlHelpers/tableHelper')({
-		_,
 		checkAllKeysDeactivated,
 		getColumnsList,
 		commentIfDeactivated,

diff --git a/forward_engineering/ddlProvider/templates.js b/forward_engineering/ddlProvider/templates.js
@@ -3,7 +3,7 @@ module.exports = {
 
 	comment: '\nCOMMENT ON ${object} ${objectName} IS ${comment};\n',
 
-	createTable: 'CREATE${tableType} TABLE${ifNotExists} ${name}${tableProps}\n${options}',
+	createTable: 'CREATE${tableType} TABLE${ifNotExists} ${name}${tableProps}${options}',
 
 	createTableProps: '${columnDefinitions}${keyConstraints}${checkConstraints}${foreignKeyConstraints}',